(bugfix): Remove an extra tmp copy of lightsetup in Simulator.cpp#1867
Merged
Skylion007 merged 1 commit intomainfrom Sep 19, 2022
Merged
(bugfix): Remove an extra tmp copy of lightsetup in Simulator.cpp#1867Skylion007 merged 1 commit intomainfrom
Skylion007 merged 1 commit intomainfrom
Conversation
Skylion007
requested review from
aclegg3,
eundersander,
jrreyna and
jturner65
facebook-github-bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Tiny performance bug in simulator.cpp relating to lighting setup. This removes an unnecessary extra copy.
How Has This Been Tested
Types of changes
Checklist