Skip to content

(bugfix): Prevent unnecessary copies with more std::move and emplace#1870

Merged
Skylion007 merged 6 commits intomainfrom
mmgrs-tmplt-handle-insert-move
Sep 22, 2022
Merged

(bugfix): Prevent unnecessary copies with more std::move and emplace#1870
Skylion007 merged 6 commits intomainfrom
mmgrs-tmplt-handle-insert-move

Conversation

@Skylion007
Copy link
Copy Markdown
Contributor

Motivation and Context

  • When I was reviewing @jturner65's PR, I noticed a series of strings that were being copied into their std::set. This explicitly moves them when inserting them into the set instead which should prevent an unnecessary copy.

How Has This Been Tested

Locally

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 22, 2022
@Skylion007 Skylion007 changed the title (bugfix): Prevent unnecessary copies of tmp handles in metadata manager (bugfix): Prevent unnecessary copies with more std::move and emplace Sep 22, 2022
Copy link
Copy Markdown
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@Skylion007 Skylion007 merged commit 45c90b9 into main Sep 22, 2022
@Skylion007 Skylion007 deleted the mmgrs-tmplt-handle-insert-move branch September 22, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants