Skip to content

chore: Add a few missing std::move to shared_ptr. #1954

Merged
Skylion007 merged 3 commits intomainfrom
skylion007-missing-moves-recorder
Nov 30, 2022
Merged

chore: Add a few missing std::move to shared_ptr. #1954
Skylion007 merged 3 commits intomainfrom
skylion007-missing-moves-recorder

Conversation

@Skylion007
Copy link
Copy Markdown
Contributor

Motivation and Context

  • This prevents some unnecessary atomic increments and decrements of a shared pointer. We only ever appear to pass the shared pointer by value anyway so this should be more efficient. The previous version of the code always performed a copy.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 30, 2022
@Skylion007 Skylion007 changed the title chore: Add missing move to setRecorder chore: Add a few missing std::move to shared pointers. Nov 30, 2022
@Skylion007 Skylion007 changed the title chore: Add a few missing std::move to shared pointers. chore: Add a few missing std::move to shared_ptr. Nov 30, 2022
@Skylion007 Skylion007 merged commit 8c4c248 into main Nov 30, 2022
@jturner65 jturner65 deleted the skylion007-missing-moves-recorder branch November 29, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants