Update to latest Magnum with full skinning support and much more#1968
Merged
Update to latest Magnum with full skinning support and much more#1968
Conversation
1ffa7e7 to
b9a5ecf
Compare
Contributor
Author
|
Anybody knows what's up with the CI? Both of the failed jobs end with a cascade of errors that have at the top. I was getting this with #1947 and thought the reason was that it was made from a fork, because if I pushed the same changes to a branch on the main repo, the CI passed. But this PR somehow doesn't. |
Contributor
|
@mosra Pull from master that should have been fixed. It's pulling the CPU only version of Torch I think. |
Contributor
Author
|
But this PR is based off current |
Contributor
|
Oh boy, did it break again? Ping @aclegg3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Upgrades Magnum to latest, containing the following:
sliceSize()API in all array, string and view classes accepting a pair of offset+size instead of begin+endlibpngupgrades more robustly, failing only in case of an ABI break"extras"from glTF nodes (such as various Floorplanner tags, shown bellow), essential also for efficient,SceneData-backed binary serialization format for gfx-replay (what's still missing is efficient bitflag representation, that's coming next)Builtin shader constructors got changed to accept a
Configurationclass because with skinning the argument count was getting out of hand. While the previous constructor signatures are still available, they're marked as deprecated so I updated the code to use the new APIs.Skinning support and skinned animation playback in the
magnum-playerutility and its prebuilt binaries, as I advertised on the call today, will arrive in the next days.How Has This Been Tested
My CIs pass.