Clear replay renderer when all instances are deleted.#1976
Merged
Conversation
facebook-github-bot
added
the
CLA Signed
eundersander
approved these changes
Dec 23, 2022
Contributor
eundersander
left a comment
eundersander
left a comment
There was a problem hiding this comment.
Left a minor comment but otherwise LGTM!
Skylion007
approved these changes
Dec 27, 2022
…h renderer memory issues.
0mdc
force-pushed
the
replay-clear-memory-on-scene-change
branch
from
53e253f to
068d48c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The batch renderer currently cannot delete individual instances. Because of this, it quickly reaches internal limits when repeatedly changing scenes. The batch renderer can however delete all instances at once.
This changeset clears the frame when the player detects that the applied keyframe is deleting all instances.
This implementation is preferred to an explicit
clearFramekeyframe flag as it doesn't force the implementer (blender script, etc) to delete its instances in a specific way. However, it cannot detect leaking instances from a misused recorder.How Has This Been Tested
Tested in python viewer by repeatedly changing scenes.
Types of changes
Checklist