Update magnum-bindings for MeshData fix on py3.7#2003
Merged
Conversation
facebook-github-bot
added
the
CLA Signed
mosra
approved these changes
Feb 10, 2023
Contributor
mosra
left a comment
mosra
left a comment
There was a problem hiding this comment.
If it compiles, it's correct :D
Skylion007
approved these changes
Feb 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Pulling small fix in magnum-bindings to handle python 3.7 error with pybind11 overload ordering. Supports Habitat-lab 1108.
See mosra/magnum-bindings@b3e24a1 for details.
How Has This Been Tested
Locally + CI passes
Types of changes
Checklist