Skip to content

--Minor fix to remove file being written by test #2013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jturner65 merged 1 commit into from
Feb 21, 2023
Merged

--Minor fix to remove file being written by test #2013

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/tests/PathFinderTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,16 +241,22 @@ void PathFinderTest::navMeshSettingsTestJSON() {

// check saving settings
esp::nav::NavMeshSettings defaultSettings;

const auto testFilepath =
Cr::Utility::Path::join(TEST_ASSETS, "test_navmeshsettings_reload.json");
// save defaults to a file
defaultSettings.writeToJSON(
Cr::Utility::Path::join(TEST_ASSETS, "test_navmeshsettings_reload.json"));
defaultSettings.writeToJSON(testFilepath);

// reload and check against original
navmeshSettings.readFromJSON(
Cr::Utility::Path::join(TEST_ASSETS, "test_navmeshsettings_reload.json"));
navmeshSettings.readFromJSON(testFilepath);

CORRADE_VERIFY(defaultSettings == navmeshSettings);

// remove file created for this test
bool success = Corrade::Utility::Path::remove(testFilepath);
if (!success) {
ESP_WARNING() << "Unable to remove temporary test JSON file"
<< testFilepath;
}
}

} // namespace
Expand Down