Merged
Conversation
jturner65
reviewed
Feb 22, 2023
jturner65
reviewed
Feb 22, 2023
Skylion007
reviewed
Feb 23, 2023
Skylion007
reviewed
Feb 23, 2023
7 tasks
jturner65
approved these changes
Feb 28, 2023
jturner65
approved these changes
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Currently, if any of the requested_end points don't snap to the navmesh,
MultiGoalShortestPathwill early abort and returninfdistance.Expected behavior: if any of the points in
requested_endsare valid, the shortest path should be computed accurately.Additional feature: adds
closest_end_point_indextoMultiGoalShortestPathstruct API. Makes it easier to know which point form the input set was actually selected as closets. Corresponds to the end of thepath.How Has This Been Tested
TODO:
May need to update tests to check these edge cases:
Types of changes
Checklist