Skip to content

don't default to joined collision objects#2021

Merged
aclegg3 merged 1 commit intomainfrom
default-no-joined-collision-objects
Mar 1, 2023
Merged

don't default to joined collision objects#2021
aclegg3 merged 1 commit intomainfrom
default-no-joined-collision-objects

Conversation

@aclegg3
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 commented Mar 1, 2023

Motivation and Context

Current default is to join all collision shapes into a single convex unless explicitly configured otherwise. This is an outdated stability consideration from a buggier time and should no longer be the default.

How Has This Been Tested

locally

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from jturner65 March 1, 2023 17:28
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 1, 2023
@aclegg3 aclegg3 merged commit bbbee82 into main Mar 1, 2023
@aclegg3 aclegg3 deleted the default-no-joined-collision-objects branch March 1, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants