Conversation
592255e to
ccbf98a
Compare
aclegg3
reviewed
Mar 15, 2023
77972dd to
5ce64b6
Compare
This reverts commit 27a1cee.
064a747 to
1acd5c1
Compare
042eac0 to
8c41b4a
Compare
8101883 to
e2f68c1
Compare
0mdc
commented
Mar 23, 2023
| git submodule update --init --recursive --jobs 8 | ||
| pip install . | ||
| pip uninstall -y habitat-sim | ||
| rm -rf build |
Contributor
Author
There was a problem hiding this comment.
This somehow makes conda build work on the osx image. We're not exactly sure why.
It adds ~13 minutes to the build stage, but we can live with it for now.
Fortunately, this hack won't be necessary when we move from setup.py install to pip install ..
Thanks @rpartsey for reproducing the issue and finding the workaround.
rpartsey
approved these changes
Mar 23, 2023
Skylion007
approved these changes
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
As Python 3.7 is nearing end-of-life, we are upgrading Habitat's minimum Python version to 3.9. Some of our dependencies are deprecating Python 3.7, like PyTorch and NumPy. We will also benefit from performance improvements and overall modernization.
Habitat-lab changeset:
How Has This Been Tested
Tested locally and on CI.
Types of changes
Checklist