Skip to content

--[PBR Update 0 of 3] Add python binding to enable IBL.#2113

Merged
jturner65 merged 1 commit intomainfrom
PBR_PythonFlag
May 18, 2023
Merged

--[PBR Update 0 of 3] Add python binding to enable IBL.#2113
jturner65 merged 1 commit intomainfrom
PBR_PythonFlag

Conversation

@jturner65
Copy link
Copy Markdown
Contributor

Motivation and Context

This PR adds a python binding to the simulatorConfig field that enables/disables image based lighting in the PBR shader.

How Has This Been Tested

C++ and python tests pass locally

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from aclegg3 May 18, 2023 21:25
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 18, 2023
@jturner65 jturner65 merged commit db89694 into main May 18, 2023
@jturner65 jturner65 deleted the PBR_PythonFlag branch May 18, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants