Skip to content

[BE week] - Remove VHACD integration#2128

Merged
aclegg3 merged 9 commits intomainfrom
remove-vhacd
Jun 13, 2023
Merged

[BE week] - Remove VHACD integration#2128
aclegg3 merged 9 commits intomainfrom
remove-vhacd

Conversation

@aclegg3
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 commented Jun 13, 2023

Motivation and Context

VHACD integration is not used commonly and based on C++ hooks into a forked repo.
Cleaner to use newer external tools such as COACD python bindings instead.

How Has This Been Tested

CI

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested review from 0mdc and jturner65 June 13, 2023 15:08
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 13, 2023
eundersander
eundersander approved these changes Jun 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@eundersander eundersander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jturner65
jturner65 approved these changes Jun 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

0mdc
0mdc approved these changes Jun 13, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@aclegg3 aclegg3 merged commit acd215b into main Jun 13, 2023
@aclegg3 aclegg3 deleted the remove-vhacd branch June 13, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jturner65 jturner65 jturner65 approved these changes

+2 more reviewers

@eundersander eundersander eundersander approved these changes

@0mdc 0mdc 0mdc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aclegg3 @jturner65 @eundersander @0mdc @facebook-github-bot