Skip to content

add clear_color to settings for rgb sensor initialization#2161

Merged
aclegg3 merged 2 commits intomainfrom
clear_color_settings
Jul 25, 2023
Merged

add clear_color to settings for rgb sensor initialization#2161
aclegg3 merged 2 commits intomainfrom
clear_color_settings

Conversation

@aclegg3
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 commented Jul 17, 2023

Motivation and Context

Expand quick start settings util to support rgb clear color.

How Has This Been Tested

CI examples and tests instantiate these sensors with settings.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 17, 2023
@aclegg3 aclegg3 requested review from 0mdc and jturner65 July 19, 2023 22:23
Copy link
Copy Markdown
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread src_python/habitat_sim/utils/settings.py Outdated
@aclegg3 aclegg3 merged commit b4d36bc into main Jul 25, 2023
@aclegg3 aclegg3 deleted the clear_color_settings branch July 25, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants