Fixed bug for directories containing spaces#2176
Merged
aclegg3 merged 2 commits intofacebookresearch:mainfrom Aug 17, 2023
Merged
Fixed bug for directories containing spaces#2176aclegg3 merged 2 commits intofacebookresearch:mainfrom
aclegg3 merged 2 commits intofacebookresearch:mainfrom
Conversation
Previously the code would not work for directories containing spaces due to the split function being called.
aclegg3
approved these changes
Aug 17, 2023
Contributor
aclegg3
left a comment
There was a problem hiding this comment.
Thanks for fixing the problem when you found it. 🙂
Sorry for the review delay.
Contributor
Author
|
No problem! I think I saw the same issue in some other places. I'll let you know if I find it elsewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Previously the code would not work for directories containing spaces (due to a split function being called). This has now been fixed.
For example, if you try to run the command:
python -m habitat_sim.utils.datasets_download --uids habitat_test_scenes --data-path ./Data"from the directory:"/Users/vishnesh/Master/Sample Folder With Spaces", you get the following error.How Has This Been Tested
This has been tested by reviewing how the path is split and by running the same command
python -m habitat_sim.utils.datasets_download --uids habitat_test_scenes --data-path ./Data"without any errors.Types of changes
Checklist