--[Habitat3.0] Removal of out-of-date/deprecated flags for IBL#2203
Merged
--[Habitat3.0] Removal of out-of-date/deprecated flags for IBL#2203
Conversation
-IBL is now controlled by settings in xxx.pbr_config.json files and programmatically via PbrShaderAttributes configurations.
facebook-github-bot
added
the
CLA Signed
aclegg3
approved these changes
Sep 13, 2023
Contributor
aclegg3
left a comment
aclegg3
left a comment
There was a problem hiding this comment.
LGTM, thanks. Note this is breaking change since the flag is removed. Any code setting the flag elsewhere may error now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
IBL is now enabled and balanced against direct lighting in the PBR shader by settings in xxx.pbr_config.json files and programmatically via PbrShaderAttributes configurations.
These flags have been ignored since the IBL rework was merged here but this PR removes them.
NOTE : This is a breaking change, in that any code that is setting the flag will now break. Any code doing this can be removed without issue, since whatever the flag is set to has been ignored since the PBR/IBL rework.
How Has This Been Tested
All existing c++ and python tests pass.
Types of changes
Checklist