Skip to content

--[Part 2 of 2] Semantic region building#2307

Merged
jturner65 merged 28 commits intomainfrom
SemanticRegionBuilding
Jan 31, 2024
Merged

--[Part 2 of 2] Semantic region building#2307
jturner65 merged 28 commits intomainfrom
SemanticRegionBuilding

Conversation

@jturner65
Copy link
Copy Markdown
Contributor

@jturner65 jturner65 commented Jan 23, 2024

Motivation and Context

This PR uses the Semantic Attributes introduced in this PR to build the Semantic Scene, including any region annotations, which are used to construct SemanticRegions.

How Has This Been Tested

Current c++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 23, 2024
@jturner65 jturner65 requested a review from aclegg3 January 23, 2024 17:44
@jturner65 jturner65 force-pushed the SemanticRegionBuilding branch 2 times, most recently from cec66b2 to 7d86961 Compare January 23, 2024 20:30
@jturner65 jturner65 marked this pull request as ready for review January 26, 2024 16:39
@jturner65 jturner65 force-pushed the SemanticRegionBuilding branch from b8b3e44 to 7e99fc7 Compare January 26, 2024 16:44
@jturner65 jturner65 force-pushed the SemanticRegionBuilding branch from f9db344 to eedb92b Compare January 29, 2024 19:11
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jturner65 jturner65 merged commit f964e51 into main Jan 31, 2024
@jturner65 jturner65 deleted the SemanticRegionBuilding branch January 31, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants