Conversation
jturner65
approved these changes
Jan 29, 2024
Contributor
jturner65
left a comment
There was a problem hiding this comment.
LGTM. This is going to removing Eigen a lot easier. Thanks!
Contributor
Author
|
Re-running the failed lab build with the lab PR merged: https://app.circleci.com/pipelines/github/facebookresearch/habitat-sim/12613/workflows/de0d49c1-7011-42bb-ac1e-18f98ff912c6/jobs/79832 I have to leave for today, feel free to merge once this build passes. (Not sure if the re-ran build shows up in the overview above, I hope it will?) |
This was referenced Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Note: Requires facebookresearch/habitat-lab#1776 in order to pass the CI. The lab PR can be merged independently, as the syntax should work even with the original code.
Another ~2 months worth of Magnum features, fixes and improvements. What's new since #2278:
constexprQuaternion::setFromTwoVectors()and similar APIs in other quaternion libraries. Related to --[BE] Remove Eigen dependency Part 1 #2301, it felt better to just put this in Magnum instead of having to maintain a utility function in Habitat.MAGNUM_BUILD_PYTHON_BINDINGS_RTLD_GLOBALCMake option for Python bindings. Enabled by default for static builds, performssys.setdlopenflags(sys.getdlopenflags()|ctypes.RTLD_GLOBAL)before loading native modules in an attempt to resolve cursed issues with deduplicating globals across shared modules that was made impossible by Python implicitly isolating each loaded module into its namespace, which was repeatedly hit by @eundersander, @0mdc and others. I'm writing very long sentences today, yes, sorry.Also updated the m.css submodule, because apparently it was untouched since December 2022(!):
docutils<video>tags the same as imagesdistutils, thus fixing compatibility with Python 3.12How Has This Been Tested
🟢