--Object/AO creation refactor and Object/AO Instance save/creation#2315
Merged
--Object/AO creation refactor and Object/AO Instance save/creation#2315
Conversation
--added suffix to internal-only add --made final function calls for adding objects and articulated objects protected to govern access.
…points --Also make sure we always save instance attributes on creation, and create empty ones for objects that do not have them.
facebook-github-bot
added
the
CLA Signed
aclegg3
approved these changes
Feb 3, 2024
Contributor
aclegg3
left a comment
aclegg3
left a comment
There was a problem hiding this comment.
Found the bug was from another source, but still a nice clean-up pass. 👍
Thanks!
jturner65
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR is intended to address an issue when saving a scene instance, where an AO 's current configuration is not being saved as a SceneAOInstance. In the process this PR also simplifies object/AO creation and makes sure some important processes always take place (which was not formerly the case) such as saving an instance creation attributes upon object/ao creation (and creating a default one if none exists)
How Has This Been Tested
All existing c++ and python tests pass.
Types of changes
Checklist