Conversation
facebook-github-bot
added
the
CLA Signed
jturner65
approved these changes
Feb 6, 2024
jturner65
approved these changes
Feb 6, 2024
Contributor
jturner65
left a comment
jturner65
left a comment
There was a problem hiding this comment.
A couple minor changes, but looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add functions to query region containment for one point and a set of points.
How Has This Been Tested
Added pytests and a demo in viewer.py.
In the below video when the crib object is selected, containing regions are displayed colored by containment percentage. Red is full containment fading to green with less containment. Notice the hues shift as the object is moved between regions.
region_contain-2024-02-05_15.35.34.mp4
Note: this demo will be reverted before merge.
Types of changes
Checklist