Skip to content

--Minor fixes and improvements#2333

Merged
jturner65 merged 1 commit intomainfrom
minor_fixes
Mar 5, 2024
Merged

--Minor fixes and improvements#2333
jturner65 merged 1 commit intomainfrom
minor_fixes

Conversation

@jturner65
Copy link
Copy Markdown
Contributor

Motivation and Context

This PR adds a few minor fixes and code improvements.

  • Adds bound access to rigid object com correction vector (translation of underlying visual node).
  • Cleans up some existing RigidObject comments referencing outdated constructs

How Has This Been Tested

All existing c++ and python tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 5, 2024
@jturner65 jturner65 requested a review from aclegg3 March 5, 2024 14:57
@jturner65 jturner65 merged commit ad6903c into main Mar 5, 2024
@jturner65 jturner65 deleted the minor_fixes branch March 5, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants