Conversation
latest miniconda is using python 3.12 which is undesirable, and causes osx builds to break.
11 tasks
0mdc
approved these changes
Mar 5, 2024
Contributor
0mdc
left a comment
There was a problem hiding this comment.
LGTM!
We'll probably want to extend support to Python 3.12 in the foreseeable future.
Contributor
Author
Yeah, definitely (supposed to be markedly faster with strings, for instance), but it will certainly require a some investigation and reworking since there are many modules that have been deprecated for a while that were removed with 3.11 and 3.12. |
aclegg3
approved these changes
Mar 5, 2024
Contributor
|
Thanks for investigating and fixing this. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Using the latest miniconda versions is referencing python 3.12 which is undesirable, and causes osx builds to break (pkgutil.ImpImporter class was deprecated in python 3.3 and removed in 3.12.)
This PR will freeze our miniconda version to most recent python 3.10 version for both linux and mac.
How Has This Been Tested
Types of changes
Checklist