Update Magnum for ASCII PLY import and artifact-free text rendering#2355
Merged
Update Magnum for ASCII PLY import and artifact-free text rendering#2355
Conversation
Contributor
aclegg3
approved these changes
Apr 2, 2024
Contributor
aclegg3
left a comment
There was a problem hiding this comment.
Tests pass, so assuming all the build changes are good. :)
Thanks, mosra!
Also, CI lint issue should be resolved on main.
jturner65
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another month+ worth of Magnum updates, this time containing two important usability features:
Besides that, the following changes are worth mentioning:
Debugclass now occupy 16.67% less memory.constexprcontexts. In practice that means better optimization opportunities for the compiler, IIRC Habitat isn't making any extensive use of this type anywhere.Findmodules were updated to properly support the case where each project is installed in a different prefix, unblocking one Habitat use case: Consider switching from the legacy Find*.cmake modules to install(TARGETS ... EXPORT ...) mosra/magnum-integration#105(Sorry, I deleted the PR template by accident. Tests are 🟢 on my end, that
mypyfailure wasn't me.)Also mentioning @aclegg3 -- can't add you as a reviewer for some reason.