Skip to content

Add instance metadata to gfx-replay.#2377

Merged
0mdc merged 3 commits intomainfrom
0mdc/gfx_replay_metadata
May 2, 2024
Merged

Add instance metadata to gfx-replay.#2377
0mdc merged 3 commits intomainfrom
0mdc/gfx_replay_metadata

Conversation

@0mdc
Copy link
Copy Markdown
Contributor

@0mdc 0mdc commented Apr 28, 2024

Motivation and Context

This changeset adds an InstanceMetadata entry to gfx-replay keyframes so that this information can be made available to external players.

This information can be used to do commands on gfx-replay instances based on real simulation IDs, for example:

  • Hiding an agent.
  • Highlighting an object's mesh.
  • Tooling.
  • ...

How Has This Been Tested

  • Added test.
  • Tested in Unity gfx-replay client.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@0mdc 0mdc requested review from aclegg3 and jturner65 April 28, 2024 22:12
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Apr 28, 2024
Copy link
Copy Markdown
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants