--Configuration : Add ability to handle vectors of fields within subconfigs#2394
Merged
--Configuration : Add ability to handle vectors of fields within subconfigs#2394
Conversation
… of data. A vector of a supported type of values can now be stored and retrieved in a Subconfiguration, where the key of each value from the vector will be a string representation of its index. Currently supports up to 1000 values in the vector.
aclegg3
approved these changes
May 10, 2024
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR takes the support for vectors of points introduced with MarkerSets, promotes it to the underlying Configuration and expands it to be vectors of any type. In a nutshell a vector of data can be stored in a subconfig by having the key be a string rep of the index in the vector referencing the value.
This obviates the need for local vectors to implementers of the Configuration class, such as SemanticAttributes, which stored the polyloop of points in a vector member varaiable.
How Has This Been Tested
Locally c++ and python tests pass.
Types of changes
Checklist