Skip to content

--Configuration : Add ability to handle vectors of fields within subconfigs#2394

Merged
jturner65 merged 3 commits intomainfrom
Configs_VecsAsConfigs
May 11, 2024
Merged

--Configuration : Add ability to handle vectors of fields within subconfigs#2394
jturner65 merged 3 commits intomainfrom
Configs_VecsAsConfigs

Conversation

@jturner65
Copy link
Copy Markdown
Contributor

@jturner65 jturner65 commented May 10, 2024

Motivation and Context

This PR takes the support for vectors of points introduced with MarkerSets, promotes it to the underlying Configuration and expands it to be vectors of any type. In a nutshell a vector of data can be stored in a subconfig by having the key be a string rep of the index in the vector referencing the value.

This obviates the need for local vectors to implementers of the Configuration class, such as SemanticAttributes, which stored the polyloop of points in a vector member varaiable.

How Has This Been Tested

Locally c++ and python tests pass.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

jturner65 added 2 commits May 10, 2024 13:54
… of data.

A vector of a supported type of values can now be stored and retrieved  in a Subconfiguration, where the key of each value from the vector will be a string representation of its index. Currently supports up to 1000 values in the vector.
@jturner65 jturner65 requested a review from aclegg3 May 10, 2024 18:31
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 10, 2024
@jturner65 jturner65 changed the title --[WIP]Configuration : Add ability to handle vectors of fields within subconfigs --Configuration : Add ability to handle vectors of fields within subconfigs May 10, 2024
@jturner65 jturner65 marked this pull request as ready for review May 10, 2024 19:03
@jturner65 jturner65 merged commit 1db01c7 into main May 11, 2024
@jturner65 jturner65 deleted the Configs_VecsAsConfigs branch May 11, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants