--[BE] - Duplicate existing rigid or articulated object#2418
Merged
Conversation
facebook-github-bot
added
the
CLA Signed
aclegg3
approved these changes
Jun 27, 2024
| void setIsCOMCorrected(bool _isCOMCorrected) { | ||
| isCOMCorrected_ = _isCOMCorrected; | ||
| } | ||
| bool getIsCOMCorreected() const { return isCOMCorrected_; } |
Contributor
There was a problem hiding this comment.
Suggested change
| bool getIsCOMCorreected() const { return isCOMCorrected_; } | |
| bool getIsCOMCorrected() const { return isCOMCorrected_; } |
Contributor
Author
There was a problem hiding this comment.
Jeeze my keyboard.
This way the object will be able to provide whether it is articulated or not even if it is upcast.
jturner65
force-pushed
the
BE_DuplicateExistingObject
branch
from
ce11be3 to
c05fe8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This function enables the easy and accurate duplication of existing rigid and articulated objects. If an object has been instantiated by an scene object/ao instance attributes, that object's state will be impacted by both its creation template and the instance attributes, which can be arcane. Instead of attempting to duplicate this process externally, the instance attributes and config template are accessed internally for the existing object and used to recreate another just like it.
How Has This Been Tested
Locally existing c++ and python tests pass. Tests to be added to verify duplication process.
Types of changes
Checklist