--[BUGFIX] Make sure empty Markerset subconfigs are removed when appropriate#2434
Merged
--[BUGFIX] Make sure empty Markerset subconfigs are removed when appropriate#2434
Conversation
facebook-github-bot
added
the
CLA Signed
Instead of asserting, return a warning along with an empty vector <T> if the named subconfig is not found. This is consistent with the behavior of other indirect subconfig queries.
It is possible to have a JSON marker set object associated with a link and task that lists no points. Due to the markersets being managed generically as nested configurations, with access accomplished via static casting, it is then possible to access a MarkerSet object that may not have a "markers" subconfig. This is a reasonable state, and should result in an assertion when attempting to query the MarkerSet.
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
If all the markers in a markerset are removed, the markerset should also be removed. This should apply to all levels of the hierarchy, so that empty (sub)objects are not written to JSON on save.
How Has This Been Tested
Locally c++ and python tests pass
Types of changes
Checklist