--[BugFix] - Handle transformations of points assigned to an AO's baselink#2444
Merged
--[BugFix] - Handle transformations of points assigned to an AO's baselink#2444
Conversation
facebook-github-bot
added
the
CLA Signed
jturner65
force-pushed
the
AO_HandleBaseLinkPoints
branch
from
7c5e54b to
02b2faa
Compare
don't use parent node to local transform.
aclegg3
approved these changes
Aug 9, 2024
Contributor
aclegg3
left a comment
aclegg3
left a comment
There was a problem hiding this comment.
LGTM, thanks for working through this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR will properly handle transformations of points assigned to the baseLink of an ArticulatedObject between local and world space. It will also accommodate transforming baseLink-assigned marker points to world space if any should exist.
How Has This Been Tested
Locally C++ and python tests.
Types of changes
Checklist