--[BE] - Refactor/cleanup attributes and attributes managers#2461
Merged
--[BE] - Refactor/cleanup attributes and attributes managers#2461
Conversation
Follow existing config/metadata naming conventions; minor reorganization of SceneDatasetAttributes
Needs to send the handle used to actually register to attributes
jturner65
commented
Sep 4, 2024
|
|
||
| /** | ||
| * @brief return if passed @p subConfig exists in this Configuration's | ||
| * subconfig map. Does not compare hidden ConfigValues. |
Contributor
Author
There was a problem hiding this comment.
This is because the hidden values are used as instance-specific, internally-used metadata that are, by design, always unique.
aclegg3
approved these changes
Sep 4, 2024
Contributor
aclegg3
left a comment
There was a problem hiding this comment.
LGTM. I don't see any issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR addresses a few things that I've wanted to take care of for a while, as well as a little bit of groundwork for future PRs. All of these changes are transparent and should have no impact on current Sim execution.
How Has This Been Tested
Locally C++ and python tests pass
Types of changes
Checklist