Skip to content

addSensorToObject() expanded#2491

Merged
aclegg3 merged 5 commits intomainfrom
alex-10_05-add_sensor_to_object_expanded
Nov 9, 2024
Merged

addSensorToObject() expanded#2491
aclegg3 merged 5 commits intomainfrom
alex-10_05-add_sensor_to_object_expanded

Conversation

@aclegg3
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 commented Nov 7, 2024

Motivation and Context

This PR expands the addSensorToObject function to cover all possible valid values for objectId and to throw an exception for invalid values.

  • adds attachment to an ArticulatedObject's root or to any link
  • adds attachment to the root SceneNode (global space) when objectId == esp::RIGID_STAGE_ID

How Has This Been Tested

Added a C++ test.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 7, 2024
Copy link
Copy Markdown
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aclegg3 aclegg3 merged commit c6939c8 into main Nov 9, 2024
@aclegg3 aclegg3 deleted the alex-10_05-add_sensor_to_object_expanded branch November 9, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants