Skip to content

--[BUGFIX] - Link missing 'assets' library to HM3DSceneTest#2501

Merged
jturner65 merged 1 commit intomainfrom
BE_HM3DTestLibs
Nov 13, 2024
Merged

--[BUGFIX] - Link missing 'assets' library to HM3DSceneTest#2501
jturner65 merged 1 commit intomainfrom
BE_HM3DTestLibs

Conversation

@jturner65
Copy link
Copy Markdown
Contributor

Motivation and Context

This PR will link to the 'assets' library for HM3DSceneTest, which otherwise has recently started failing due to required Importers not being found. Not sure of the cause, or why this is only happening locally on my machine (currently) but this addresses the issue.

How Has This Been Tested

Locally C++ tests pass

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 13, 2024
@jturner65 jturner65 requested a review from aclegg3 November 13, 2024 16:50
Copy link
Copy Markdown
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, must have missed this without the assets locally.

@jturner65 jturner65 merged commit 5176e08 into main Nov 13, 2024
@jturner65 jturner65 deleted the BE_HM3DTestLibs branch November 13, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants