--Update Attributes creation messages to be clearer.#923
--Update Attributes creation messages to be clearer.#923jturner65 merged 2 commits intofacebookresearch:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
| ") not parseable configuration file, so new default"; | ||
| } else { | ||
| msg = "New default (" + filename + ")"; | ||
| msg = filename + " file not found so new default"; |
There was a problem hiding this comment.
Yes. This is meant to inform the user that what they passed was not found in the file system (neither as a configuration file, nor as an appropriate asset that can be used to build a default configuration), so they were given a new one built from the specified default attributes' template. This is meant to inform in case they perhaps spelled the name wrong, and wished to have one built from either a json file or an existing non-json asset.
There was a problem hiding this comment.
| msg = filename + " file not found so new default"; | |
| msg = filename + " file not found so using \"new\" default"; |
There was a problem hiding this comment.
Actually that doesn't really work - this message is prepended to "< attributes type > created"
<< (registerTemplate ? " and registered." : ".");
There was a problem hiding this comment.
So for example, one feasible output is :
8: I1109 16:33:15.267932 14811 AbstractObjectAttributesManagerBase.h:180] new_default_attributes file not found so new default Stage attributes created.
jturner65
force-pushed
the
MM_ClearerCreationMessages
branch
from
6d503d7 to
d3436ba
Compare
jturner65
force-pushed
the
MM_ClearerCreationMessages
branch
from
dc16be4 to
1b50e4d
Compare
…h#923) * --Update Attributes creation messages to be clearer. * --Reviewer suggestions
3 participants
Motivation and Context
Attributes creation messages were a bit arcane, so this PR hopes to clarify what exactly is going on.
How Has This Been Tested
C++ and python tests pass
Types of changes
Checklist