Skip to content

[bugfix] fix a useless assertion#939

Merged
bigbike merged 1 commit intomasterfrom
fix-uint
Nov 17, 2020
Merged

[bugfix] fix a useless assertion#939
bigbike merged 1 commit intomasterfrom
fix-uint

Conversation

@bigbike
Copy link
Copy Markdown
Contributor

@bigbike bigbike commented Nov 17, 2020

Motivation and Context

As titled.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 17, 2020
@Skylion007
Copy link
Copy Markdown
Contributor

Skylion007 commented Nov 17, 2020

LGTM, let's merge.

jturner65
jturner65 approved these changes Nov 17, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@jturner65 jturner65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigbike bigbike merged commit 7d37980 into master Nov 17, 2020
@bigbike bigbike deleted the fix-uint branch November 17, 2020 22:15
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
@bigbike
fix a useless assertion (facebookresearch#939)
4e70257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jturner65 jturner65 jturner65 approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

+1 more reviewer

@Skylion007 Skylion007 Skylion007 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed Do not delete this pull request or issue due to inactivity.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bigbike @Skylion007 @jturner65 @facebook-github-bot