-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Support reading uv and uv map for ply format if texture_uv exists in ply file #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
55c1892
fd6017f
bffc328
5d94660
3f4affb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1073,7 +1073,7 @@ def join_batch(self, textures: List["TexturesUV"]) -> "TexturesUV": | |
faces_uvs_list += self.faces_uvs_list() | ||
verts_uvs_list += self.verts_uvs_list() | ||
maps_list += self.maps_list() | ||
num_faces_per_mesh = self._num_faces_per_mesh | ||
num_faces_per_mesh = self._num_faces_per_mesh.copy() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This also looks like a separate significant bug you've fixed, best in its own PR. Thanks again. Probably the test change would be an extra assertion in an existing test. (Or let us know and we can sort it out. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In fact, I think TexturesAtlas has exactly the same bug. They should be fixed at the same time. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, this is a significant bug which was found when I was using Pytorch3D. Specifically, for meshes with TextureUV, calling function There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. Let me sort it out. Best to remove this change from this PR still. |
||
for tex in textures: | ||
verts_uvs_list += tex.verts_uvs_list() | ||
faces_uvs_list += tex.faces_uvs_list() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a significant bug you are fixing, which is separate from this change. Thank you. It would be good to put it in its own PR which would include a test for this problem.
(Or let us know and we can do it internally.)