Skip to content

Speed up save_obj function, add option of saving normals. #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Speed up save_obj function, add option of saving normals. #667

wants to merge 1 commit into from

Conversation

Talmaj
Copy link
Contributor

@Talmaj Talmaj commented May 6, 2021

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 6, 2021
@Talmaj Talmaj force-pushed the save_obj_extension branch from cf8b57b to 33c7a79 Compare May 6, 2021 10:57
@Talmaj
Copy link
Contributor Author

Talmaj commented May 6, 2021

After I've read into np.vectorize and np.apply_along_axis it is probably not speeding up the function. There is also a bug with strings and np.apply_along_axis: numpy/numpy#8352
I've re-opened a pull request with added normals only.

@Talmaj Talmaj closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Talmaj @facebook-github-bot