This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Add passthrough rescaler + Git CI style checker #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
EntilZha
force-pushed
the
pr-passthrough-rescaler
branch
3 times, most recently
from
222bf5e to
f4a377c
Compare
EntilZha
force-pushed
the
pr-passthrough-rescaler
branch
from
f4a377c to
faca41e
Compare
Contributor
Author
|
Moved this to CircleCI @xiaomengy so probably good to go? Seems to be passing on the circleci on my fork https://app.circleci.com/pipelines/github/EntilZha/rlmeta/3/workflows/fcf82992-128f-42f0-82b3-b0f10dc31e30/jobs/3 and should auto-start working once merged on the main rlmeta circleci. |
xiaomengy
reviewed
May 20, 2022
| """ | ||
|
|
||
|
|
||
| class PassthroughRescaler(Rescaler): |
Contributor
There was a problem hiding this comment.
Can we consider to rename it as IdentityRescaler ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds:
Tested the build on my fork here after adding this PR branch (then deleting it before making PR)
