Skip to content

making Singelton pattern #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

making Singelton pattern #256

wants to merge 1 commit into from

Conversation

mikelfried
Copy link

@mikelfried mikelfried commented Dec 29, 2018

Adding the Singelton Pattern

@codecov-io
Copy link

Codecov Report

Merging #256 into master will decrease coverage by 0.01%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   97.75%   97.74%   -0.02%     
==========================================
  Files          61       62       +1     
  Lines        2276     2301      +25     
==========================================
+ Hits         2225     2249      +24     
- Misses         51       52       +1
Impacted Files Coverage Δ
creational/singelton.py 96% <96%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 887582c...f3cd6c1. Read the comment docs.

@faif
Copy link
Owner

faif commented Dec 29, 2018

Hi,

Thanks for the pull request but there are no plans to add singleton to this repository. See past discussion in #233 and #226

@faif faif closed this Dec 29, 2018
@gyermolenko
Copy link
Contributor

hi @faif . maybe we could add this pattern as "no go" into readme, with corresponding remark?
Not everybody will look through closed issues to see your comments.
And people definitely talk about this pattern a lot.

@faif faif added the wontfix label Dec 30, 2018
@faif
Copy link
Owner

faif commented Dec 30, 2018

Added the wontfix label, that should help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants