[1673] Ensure mix_case returns at least one lower and one upper case … #1694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpleslie
force-pushed
the
issue-1673-password-mix-case
branch
3 times, most recently
from
6a329d6 to
db77d36
Compare
Zeragamba
suggested changes
Aug 20, 2019
Contributor
Zeragamba
left a comment
Zeragamba
left a comment
There was a problem hiding this comment.
Tests look good to me, and adding both min_alpha and min_numaric makes sense to me.
Contributor
|
Oh, and docs need to be updated. If possible it would be nice if you could include Yard style docs since that's in the pipeline, but not required. |
bpleslie
force-pushed
the
issue-1673-password-mix-case
branch
from
db77d36 to
cac7ab8
Compare
Zeragamba
suggested changes
Aug 20, 2019
bpleslie
force-pushed
the
issue-1673-password-mix-case
branch
from
cac7ab8 to
1b9d99c
Compare
Member
Author
|
Working on the docs now 👍 |
bpleslie
force-pushed
the
issue-1673-password-mix-case
branch
4 times, most recently
from
ff690bb to
2a7af9f
Compare
vbrazo
reviewed
Aug 20, 2019
lib/faker/default/alphanumeric.rb
Outdated
| ALPHABET = ('a'..'z').to_a | ||
| ALPHANUMS = ALPHABET + (0..9).to_a | ||
| NUMBERS = (0..9).to_a | ||
| ALPHANUMS = ALPHABET + NUMBERS |
vbrazo
reviewed
Aug 20, 2019
| Faker::Lorem.characters #=> "uw1ep04lhs0c4d931n1jmrspprf5wrj85fefue0y7y6m56b6omquh7br7dhqijwlawejpl765nb1716idmp3xnfo85v349pzy2o9rir23y2qhflwr71c1585fnynguiphkjm8p0vktwitcsm16lny7jzp9t4drwav3qmhz4yjq4k04x14gl6p148hulyqioo72tf8nwrxxcclfypz2lc58lsibgfe5w5p0xv95peafjjmm2frkhdc6duoky0aha" | ||
| Faker::Lorem.characters(number: 10) #=> "ang9cbhoa8" | ||
| Faker::Lorem.characters(number: 10, min_alpha: 4) #=> "ang9cbhoa8" | ||
| Faker::Lorem.characters(number: 10, min_alpha: 4, min_numeric: 1) #=> "ang9cbhoa8" |
Zeragamba
suggested changes
Aug 20, 2019
bpleslie
force-pushed
the
issue-1673-password-mix-case
branch
2 times, most recently
from
97b9cee to
9e8feb4
Compare
Member
Author
|
@Zeragamba @vbrazo I believe I have addressed all of your feedback. Let me know if you see anything else 👍 |
bpleslie
force-pushed
the
issue-1673-password-mix-case
branch
from
9e8feb4 to
76566d9
Compare
Member
|
@bpleslie could you rebase and fix the conflicts? |
bpleslie
force-pushed
the
issue-1673-password-mix-case
branch
from
76566d9 to
0e8439f
Compare
bpleslie
force-pushed
the
issue-1673-password-mix-case
branch
from
0e8439f to
942091a
Compare
Member
Author
|
@vbrazo we should be all set here |
vbrazo
added a commit
that referenced
this pull request
Aug 28, 2019
* Bump to version 2.2.0 * Add #1694
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
* Bump to version 2.2.0 * Add faker-ruby#1694
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
* Bump to version 2.2.0 * Add faker-ruby#1694
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…letter
Resolves Issue #1673
Description:
In order to ensure that at least one lowercase and one uppercase letter was returned when passing
mix_case: truetoInternet.password, I did the following:Alphanumeric.alphanumericto acceptmin_alphaandmin_numericparams. (Note:min_numericis not used, but seemed equally helpful for certain situations. I'm happy to remove it if desired.)min_alphainInternet.passwordaltered themix_casecondition to ensure we always return at least one uppercase and one lowercase letter ifmix_caseistrue.