Skip to content

fix(README.md): correct falco logo image url #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

shuuji3
Copy link
Contributor

@shuuji3 shuuji3 commented Dec 30, 2024

It seems that the repository move broke the image URL in README file.

Before

Screenshot of README: "falco logo" text is shown instead of logo image

After

Screenshot of README: falco logo is shown correctly

@shuuji3
Copy link
Contributor Author

shuuji3 commented Dec 31, 2024

It seems like CI error is unrelated to this change.

@Tobi-De
Copy link
Member

Tobi-De commented Dec 31, 2024

Yes, @shuuji3
I haven’t merged this yet because I’ve been basically rewriting and changing a lot in the project. The current README will change anyway, and I’ll probably release a new version of this project and the others in the org in the coming days, assuming all goes well.

@Tobi-De Tobi-De merged commit 22598e6 into falcopackages:main Dec 31, 2024
1 check failed
@shuuji3
Copy link
Contributor Author

shuuji3 commented Dec 31, 2024

@Tobi-De Ah, I understood. Sorry for not knowing such background activity and bothering you unnecessarily. 🙏

@shuuji3 shuuji3 deleted the patch-2 branch December 31, 2024 09:17
@Tobi-De
Copy link
Member

Tobi-De commented Dec 31, 2024

@Tobi-De Ah, I understood. Sorry for not knowing such background activity and bothering you unnecessarily. 🙏

No worries, please don’t get me wrong—I really appreciate the help. You couldn’t have known about the background work. The project’s in a messy state right now anyway, so don’t hesitate if you want to help fix something!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants