Remove the NoReturn return type#232
Merged
wu-clan merged 1 commit intofastapi-practices:masterfrom Oct 22, 2023
wu-clan:delete-NoReturn-typing
Merged
Remove the NoReturn return type#232wu-clan merged 1 commit intofastapi-practices:masterfrom wu-clan:delete-NoReturn-typing
wu-clan merged 1 commit intofastapi-practices:masterfrom
wu-clan:delete-NoReturn-typing
Conversation
downdawn
approved these changes
Oct 22, 2023
Collaborator
|
Why? Is there anything bad about it? |
Member
Author
|
NoReturn should be used in infinite loop functions or system API functions, for regular returns, returning None is more friendly |
Member
Author
|
Look here: python/typing#165 |
Collaborator
|
OK |
chuxijin
pushed a commit
to chuxijin/fba
that referenced
this pull request
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLR.