Skip to content

Add department-related interfaces and others #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 9, 2023
Merged

Add department-related interfaces and others #101

merged 19 commits into from
Jun 9, 2023

Conversation

wu-clan
Copy link
Member

@wu-clan wu-clan commented Jun 7, 2023

WIP.

@wu-clan wu-clan requested a review from downdawn June 8, 2023 22:17
@wu-clan
Copy link
Member Author

wu-clan commented Jun 8, 2023

In the meantime, did something unrelated to this title 😂

@wu-clan
Copy link
Member Author

wu-clan commented Jun 8, 2023

please review.

@wu-clan wu-clan changed the title Add department-related interfaces Add department-related interfaces and others Jun 8, 2023
@downdawn
Copy link
Collaborator

downdawn commented Jun 9, 2023

19 commits, awesome!!

@wu-clan
Copy link
Member Author

wu-clan commented Jun 9, 2023

Now, perhaps AccessMiddleware can be removed, and if so, I will submit.

@downdawn
Copy link
Collaborator

downdawn commented Jun 9, 2023

Now, perhaps AccessMiddleware can be removed, and if so, I will submit.

I still expect to keep it. Using loguru will automatically manage the log size and quantity without causing the memory to be full. It may be used with other tools later, such as filebeat, es.

The operation log is stored in the MySQL database, but further maintenance is required, such as partitioning, compression, archiving, and regular cleaning.

@wu-clan
Copy link
Member Author

wu-clan commented Jun 9, 2023

I think I get it, agreed.

@wu-clan wu-clan merged commit 6c5e7a6 into fastapi-practices:master Jun 9, 2023
@wu-clan wu-clan deleted the dept-interfaces branch June 9, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants