Skip to content

opera_log_middleware method split #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 10, 2023
Merged

opera_log_middleware method split #105

merged 6 commits into from
Jun 10, 2023

Conversation

downdawn
Copy link
Collaborator

@downdawn downdawn commented Jun 9, 2023

  • opera_log_middleware method split
  • extract ip and ua information
  • added ua and ip information to login log and operation log

* extract ip and ua information
* added ua and ip information to login log and operation log
@downdawn downdawn requested a review from wu-clan June 9, 2023 10:03
@downdawn
Copy link
Collaborator Author

please review.

Copy link
Member

@wu-clan wu-clan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

@downdawn
Copy link
Collaborator Author

fixed

@wu-clan
Copy link
Member

wu-clan commented Jun 10, 2023

Great!

@wu-clan wu-clan merged commit c4c835c into fastapi-practices:master Jun 10, 2023
@downdawn downdawn deleted the opera_log_middleware_method_split branch June 17, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants