Skip to content

add the get project config api #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2023
Merged

add the get project config api #33

merged 2 commits into from
May 11, 2023

Conversation

wu-clan
Copy link
Member

@wu-clan wu-clan commented May 7, 2023

No description provided.

@wu-clan wu-clan requested a review from downdawn May 7, 2023 19:47
@downdawn
Copy link
Collaborator

downdawn commented May 8, 2023

Can the password also be obtained? won't it be too dangerous

@wu-clan
Copy link
Member Author

wu-clan commented May 8, 2023

This api requires super administrator access, unless the account or token is leaked?

@wu-clan
Copy link
Member Author

wu-clan commented May 8, 2023

This should be just a temporary api.

@downdawn
Copy link
Collaborator

downdawn commented May 8, 2023

In any case, important information such as passwords should be avoided from being connected to the internet as much as possible, as unknown vulnerabilities cannot be ruled out.

@wu-clan
Copy link
Member Author

wu-clan commented May 8, 2023

Agreed

@wu-clan
Copy link
Member Author

wu-clan commented May 9, 2023

Hi, @downdawn

What do you think about some of the database related?

E.g.:

host, port...

@downdawn
Copy link
Collaborator

What is the purpose of this API?

If we want to display it, we can desensitize the sensitive information.

@wu-clan
Copy link
Member Author

wu-clan commented May 10, 2023

As I said above, it is temporary and only for debugging.

I think it will be deleted later.

@wu-clan wu-clan merged commit a19d942 into fastapi-practices:master May 11, 2023
@wu-clan wu-clan deleted the get-config-api branch May 11, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants