Skip to content

Fix data permission condition for filter data #650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions backend/common/security/permission.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,11 @@ async def filter_data_permission(db: AsyncSession, request: Request) -> ColumnEl
:return:
"""
# 是否过滤数据权限
if request.user.is_superuser:
return or_(1 == 1)

for role in request.user.roles:
if role.is_filter_scopes:
if not role.is_filter_scopes:
return or_(1 == 1)

# 获取数据范围
Expand All @@ -71,8 +74,8 @@ async def filter_data_permission(db: AsyncSession, request: Request) -> ColumnEl
# 转换为列表
data_scopes = list(unique_data_scopes.values())

# 超级管理员和无规则用户不做过滤
if request.user.is_superuser or not data_scopes:
# 无规则用户不做过滤
if not data_scopes:
return or_(1 == 1)

# 获取数据范围规则
Expand Down