add login logs #76
Merged
add login logs #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @downdawn Routine log entry may lead to unnecessary time loss? What do you think? |
|
please review. |
The main delay is caused by the request url, can increase the timeout parameter Log storage includes operations such as parsing ua and obtaining ip information, which can be extracted into tasks separately. Consider whether to use BackgroundTasks |
|
Okay. The default timeout is 5s. |
# Conflicts: # backend/app/api/v1/user.py # backend/app/crud/crud_user.py # backend/app/services/user_service.py
|
Hi, @downdawn Now it's elegant, please review. |
downdawn
approved these changes
May 27, 2023
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-built version
Please note: This method will cause unnecessary delays in the login api