Fix background task not executed #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
downdawn
approved these changes
May 31, 2023
backend/app/services/user_service.py
Outdated
| background_tasks.add_task(LoginLogService.create, **login_logs_params) | ||
| raise errors.AuthorizationError(msg=e.msg) | ||
| err_log_info = dict( | ||
| db=db, request=request, user=current_user, login_time=self.login_time, status=0, msg=e.msg |
There was a problem hiding this comment.
Is it possible to combine status and msg? Define status with enumeration to represent different errors
There was a problem hiding this comment.
Let's do the status like this.
# Conflicts: # backend/app/services/user_service.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom exception class now supports background params, which are the same as the native JSONResponse, for usage please visit the Starlette documentation