Skip to content
This repository was archived by the owner on Mar 29, 2025. It is now read-only.

feat: create custom dynamic menus and re-format#6

Merged
wu-clan merged 3 commits into
fastapi-practices:masterfrom
wu-clan:create-dynamic-menu
Jul 1, 2023
Merged

feat: create custom dynamic menus and re-format#6
wu-clan merged 3 commits into
fastapi-practices:masterfrom
wu-clan:create-dynamic-menu

Conversation

@wu-clan

@wu-clan wu-clan commented Jun 30, 2023

Copy link
Copy Markdown
Member

@wu-clan
wu-clan requested a review from downdawn June 30, 2023 13:22
@wu-clan

wu-clan commented Jun 30, 2023

Copy link
Copy Markdown
Member Author

please review.

@downdawn

Copy link
Copy Markdown
Collaborator

What formatting tool are you using?
Actually, the Arco project was initialized with Husky configuration, but I removed it for convenience when committing.

@wu-clan

wu-clan commented Jul 1, 2023

Copy link
Copy Markdown
Member Author

Yes, husky for git

The formatting of this PR is just a simple formatting based on webstom, including optimized import, sorting (alphabetical order, empty lines of code), no specific coding specification

@wu-clan

wu-clan commented Jul 1, 2023

Copy link
Copy Markdown
Member Author

The final specification is eslint

@wu-clan

wu-clan commented Jul 1, 2023

Copy link
Copy Markdown
Member Author

We can pick up husky again

@downdawn

downdawn commented Jul 1, 2023

Copy link
Copy Markdown
Collaborator

OK

Comment thread src/hooks/user.ts
@downdawn

downdawn commented Jul 1, 2023

Copy link
Copy Markdown
Collaborator

LGTM.

@wu-clan
wu-clan merged commit 2fee92f into fastapi-practices:master Jul 1, 2023
@wu-clan
wu-clan deleted the create-dynamic-menu branch July 1, 2023 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants