♻️ Remove redundant item deletion code leveraging cascade delete (#1481)

nauanbek · web-flow · commit 15f41f755b60 · 2025-02-10T19:23:04.000Z
diff --git a/backend/app/api/routes/users.py b/backend/app/api/routes/users.py
@@ -134,8 +134,6 @@ def delete_user_me(session: SessionDep, current_user: CurrentUser) -> Any:
         raise HTTPException(
             status_code=403, detail="Super users are not allowed to delete themselves"
         )
-    statement = delete(Item).where(col(Item.owner_id) == current_user.id)
-    session.exec(statement)  # type: ignore
     session.delete(current_user)
     session.commit()
     return Message(message="User deleted successfully")

Original file line number	Diff line number	Diff line change
`@@ -134,8 +134,6 @@ def delete_user_me(session: SessionDep, current_user: CurrentUser) -> Any:`
`134`	`134`	`raise HTTPException(`
`135`	`135`	`status_code=403, detail="Super users are not allowed to delete themselves"`
`136`	`136`	`)`
`137`		`- statement = delete(Item).where(col(Item.owner_id) == current_user.id)`
`138`		`- session.exec(statement) # type: ignore`
`139`	`137`	`session.delete(current_user)`
`140`	`138`	`session.commit()`
`141`	`139`	`return Message(message="User deleted successfully")`