Skip to content

♻️ Remove redundant item deletion code leveraging cascade delete #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nauanbek
Copy link
Contributor

@nauanbek nauanbek commented Feb 4, 2025

Remove manual item deletion - cascade delete handles this

@nauanbek nauanbek marked this pull request as ready for review February 4, 2025 02:55
@alejsdev alejsdev changed the title Remove redundant item deletion code leveraging cascade delete ♻️ Remove redundant item deletion code leveraging cascade delete Feb 10, 2025
@alejsdev alejsdev merged commit 15f41f7 into fastapi:master Feb 10, 2025
31 of 33 checks passed
@alejsdev
Copy link
Member

Good catch, thank you! @nauanbek 🚀

JBLangton pushed a commit to JBLangton/full-stack-fastapi-template that referenced this pull request Mar 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants