Skip to content
Discussion options

You must be logged in to vote

So the whole point of not importing rich_utils unconditionally, was to avoid the overhead of importing rich stuff that might not actually be needed (cf detailed analysis here). I think overal that's a really nice performance gain for many use-cases, but I can see the problem when downstream libraries assume all of this stuff (including the things in rich_utils itself) are imported by default. Then again, we didn't expose it in __init__.py and I would personally always import the submodule first.

I see that safety has already merged the fix. Just to be sure, I'll run this by Tiangolo quickly to see whether we want to change anything on our end.

[UPDATE]: just confirming that we don't inten…

Replies: 4 comments

Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Comment options

You must be logged in to vote
0 replies
Answer selected by svlandeg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Question or problem
3 participants