DotfileManager: add initial dotfile manager detection #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds initial support for detecting the user's dotfile manager, addressing issue #1696. Key changes include:
- Adding dotfile manager options and initialization/cleanup hooks in options and modules.
- Implementing detection logic for bare git repositories, chezmoi, and YADM.
- Introducing new dotfile manager module files to integrate the detection and reporting.
Reviewed Changes
Copilot reviewed 11 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/options/modules.h and modules.c | Added dotfileManager option setup and corresponding init/destroy |
| src/modules/options.h and modules.h | Included dotfilemanager headers for module integration |
| src/modules/dotfilemanager/* | Added module option, header, and implementation for dotfile manager |
| src/detection/dotfilemanager/* | Implemented detection functions and README for dotfile manager |
| src/common/modules.c | Added dotfileManager to the modules list |
Files not reviewed (3)
- CMakeLists.txt: Language not supported
- doc/json_schema.json: Language not supported
- presets/all.jsonc: Language not supported
Comments suppressed due to low confidence (2)
src/detection/dotfilemanager/dotfilemanager.c:52
- New dotfile manager detection functionality is introduced; please add tests to cover each detection case (bare git repository, chezmoi, and YADM).
const char* ffDetectDotfileManager(FFDotfileManagerResult* result)
src/modules/dotfilemanager/dotfilemanager.c:108
- [nitpick] The icon string '' used for initializing module args may not render consistently across all environments; consider verifying its suitability or documenting its intended behavior.
ffOptionInitModuleArg(&options->moduleArgs, "");
CarterLi
reviewed
Apr 19, 2025
|
|
||
| ### Home manager | ||
|
|
||
| [Home manager](https://github.com/nix-community/home-manager) has no standard |
There was a problem hiding this comment.
This is frustrating. As far as I know it's commonly used by Nix community
CarterLi
reviewed
Apr 19, 2025
| ffStrbufSetS(&result->name, "bare git repository"); | ||
| return true; | ||
| } | ||
|
|
There was a problem hiding this comment.
You should also check if git is installed
CarterLi
reviewed
Apr 19, 2025
| ffStrbufAppendS(&fullPath, "chezmoi"); | ||
|
|
||
| if (ffPathExists(fullPath.chars, FF_PATHTYPE_DIRECTORY)) { | ||
| ffStrbufSetS(&result->name, "chezmoi"); |
There was a problem hiding this comment.
Check if chezmoi command exists
CarterLi
reviewed
Apr 19, 2025
| ffStrbufSet(&fullPath, configDir); | ||
| ffStrbufAppendS(&fullPath, "yadm"); | ||
|
|
||
| if (ffPathExists(fullPath.chars, FF_PATHTYPE_DIRECTORY)) { |
|
Optionally, check version of these managers. |
|
Thanks for the speedy review! I'll have time to work on this again in a few days and will address all your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1696.